Comments on: HTML Entities http://twoguysarguing.wordpress.com/2009/04/01/html-entities/ colorful back and forth from two highly opinionated programmers Tue, 18 Jun 2013 10:05:51 +0000 hourly 1 http://wordpress.com/ By: youngnh http://twoguysarguing.wordpress.com/2009/04/01/html-entities/#comment-52 Wed, 27 May 2009 14:51:01 +0000 http://twoguysarguing.wordpress.com/?p=102#comment-52 I did actually. Take a look at my github commit for it: http://github.com/youngnh/env-js/commit/e4dbe77725300f667337b36531142e89e718f867 Line 3446 is the start of the meat of the change. (on a side note, I wish I knew how to commit only textual and not whitespace changes in git)

I sent Thatcher (the current maintainer of env-js) a pull request and I think he incorporated my changes.

It basically consisted of checking while parsing if the parser was in a script tag or not and then only replacing html entities if it wasn’t.

I wasn’t very happy with my solution because it’s really only a band-aid over the larger problem of env-js lacking a proper HTML parser. The parser it has right now, I believe, is only a simple XML SAX parser. There’s been a flurry of activity on env-js that I haven’t been following very well lately, so this may no longer be the case.

]]> By: benjaminplee http://twoguysarguing.wordpress.com/2009/04/01/html-entities/#comment-51 Wed, 27 May 2009 14:35:51 +0000 http://twoguysarguing.wordpress.com/?p=102#comment-51 Did you ever finish the patch?

]]>